This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Adding Devbox pools and schedules#24
Merged
arnaudlh merged 12 commits intomicrosoft:mainfrom Jun 27, 2025
Merged
Conversation
- Upgrade azurecaf provider version to 1.2.29. - Enhance SKU configuration to support both simple name and full object. - Introduce os_storage_type variable for OS disk configuration. - Simplify hibernate_support to a boolean value. - Enable schema validation for azapi resource. - Add new outputs for image validation status and details. - Create comprehensive unit tests for Dev Box Definition module. - Update README with test coverage and instructions.
- Introduced a new Terraform module for managing Azure DevCenter project pool schedules. - Implemented features including flexible schedule types (StopDevBox, StartDevBox), time zone support, and state management. - Added comprehensive variable validation for time formats, types, and states. - Included automatic merging of global and resource-specific tags. - Integrated with the AzAPI provider using the latest Azure API preview version. - Created README documentation with usage examples, requirements, and validation details. - Developed unit tests for the new module to ensure functionality and correctness.
- Resolve conflict in tests/run_tests.sh by keeping dynamic test discovery - Merge changes from upstream main including updates to: - .devcontainer/devcontainer.json - .vscode/mcp.json - README.md - docs/getting_started.md
arnaudlh
requested review from
Copilot and
raffertyuy
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for DevCenter project pools and separate scheduling, including new root variables, module invocations, module code, and updated test discovery.
- Added root variables for
dev_center_project_poolsanddev_center_project_pool_schedulesand removed an unused environment types variable - Instantiated the new
dev_center_project_poolanddev_center_project_pool_schedulemodules indev_center_project_pools.tfanddev_center_project_pool_schedules.tf - Created the schedule module (
modules/dev_center_project_pool_schedule) and enhancedtests/run_tests.shwith dynamic test discovery and root initialization
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| variables.tf | Defined dev_center_project_pools & dev_center_project_pool_schedules; removed unused variable; added regions to global settings |
| dev_center_project_pools.tf | Instantiates dev_center_project_pool module |
| dev_center_project_pool_schedules.tf | Instantiates dev_center_project_pool_schedule module |
| modules/dev_center_project_pool_schedule/module.tf | Implements schedule resource, using fixed "default" name |
LaurentLesle
approved these changes
Jun 24, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive updates to Terraform code and documentation, focusing on Azure DevCenter module enhancements, best practices, and new configurations. The changes include detailed implementation guidelines, example configurations, and module updates to ensure compatibility with the latest API version and improved usability. Below are the most important changes grouped by theme:
Documentation Enhancements
.github/copilot-instructions.md: Added instructions for writing/updating Terraform code and documenting changes inCHANGELOG.md. Includes guidance on categorizing changes (bug fix, feature, improvement) and assessing breaking changes..github/instructions/devbox-tf.instructions.md: Introduced detailed Terraform implementation guidelines, including provider constraints, repository structure, variable typing, and security best practices. Added examples and validation patterns to ensure code quality.Module Updates
dev_center_project_pool_schedules.tf: Added a new module for managing DevCenter project pool schedules separately from pools, improving reusability.dev_center_project_pools.tf: Updated the DevCenter project pools module to support dynamic configurations, including fallback mechanisms for IDs and locations.Configuration Examples
examples/dev_center_project_pool/enhanced_case/configuration.tfvars: Added a comprehensive example configuration for enhanced DevCenter project pools, including global settings, resource groups, and detailed pool definitions for frontend and backend teams.examples/dev_center_project_pool/simple_case/configuration.tfvars: Provided a simplified example configuration for DevCenter project pools, focusing on basic settings and a single pool definition.Change Log Updates
CHANGES_SUMMARY.md: Documented recent changes, including merge conflict resolutions, TFLint compliance fixes, and updates to the test runner for dynamic discovery and initialization. Ensured all modules pass validation without warnings.MCP Server Configuration
.vscode/mcp.json: Added GitHub MCP server configuration to integrate with Copilot for advanced automation.